Merged
Conversation
This was done so that the test wouldn't panic when it fails. It's still unclear why it failed and is now passing.
This was done because the errors in question mean the test cannot meaningfully continue. This prevents a panic.
scruzin
approved these changes
Apr 28, 2025
Collaborator
scruzin
left a comment
scruzin
left a comment
There was a problem hiding this comment.
It would be good to understand the root cause of the failure, though.
Collaborator
Author
Yeah, that would be good. I'm actually running into it again so might do more more investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done so that the test wouldn't panic when it fails. It's still unclear why it failed and is now passing.
Fixes the panic in issue #542