otv & bench: add notification suppression rules#549
Conversation
5fa6718 to
ed3a265
Compare
ao-david
left a comment
There was a problem hiding this comment.
LGTM. Are you planning on adding a more user-friendly UI for this, or do you want to write an issue for this, and get someone else to tackle?
Also, I wonder whether it would be possible/useful to have site wide supression rules (although I think that this should be handled by bench rather than oceantv)
Could add a more user friendly UI for this, but also not sure how much it adds given that it's just an advanced admin feature that will hopefully be updated only rarely. Personally wouldn't even add the noise of an issue given it's low priority and triviality, but I could be convinced otherwise. |
I think that we should see how we end up using it and if it becomes necessary I guess |
ed3a265 to
7f34990
Compare
This allows us to add notification rules through the broadcast page.
This means we can suppress notifications of a particular kind or
containing a particular string. The rules are in a JSON format:
{ "SuppressKinds" : ["kind1","kind2", ... ], "SuppressContaining": ["some str"] }
7f34990 to
eccc802
Compare
This allows us to add notification rules through the broadcast page. This means we can suppress notifications of a particular kind or containing a particular string. The rules are in a JSON format: { "SuppressKinds" : ["kind1","kind2", ... ], "SuppressContaining": ["some str"] }