Skip to content

otv & bench: add notification suppression rules#549

Merged
saxon-milton merged 1 commit intomainfrom
notification-suppression
May 2, 2025
Merged

otv & bench: add notification suppression rules#549
saxon-milton merged 1 commit intomainfrom
notification-suppression

Conversation

@saxon-milton
Copy link
Member

This allows us to add notification rules through the broadcast page. This means we can suppress notifications of a particular kind or containing a particular string. The rules are in a JSON format: { "SuppressKinds" : ["kind1","kind2", ... ], "SuppressContaining": ["some str"] }

Copy link
Member

@ao-david ao-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you planning on adding a more user-friendly UI for this, or do you want to write an issue for this, and get someone else to tackle?

Also, I wonder whether it would be possible/useful to have site wide supression rules (although I think that this should be handled by bench rather than oceantv)

@saxon-milton
Copy link
Member Author

LGTM. Are you planning on adding a more user-friendly UI for this, or do you want to write an issue for this, and get someone else to tackle?

Also, I wonder whether it would be possible/useful to have site wide supression rules (although I think that this should be handled by bench rather than oceantv)

Could add a more user friendly UI for this, but also not sure how much it adds given that it's just an advanced admin feature that will hopefully be updated only rarely. Personally wouldn't even add the noise of an issue given it's low priority and triviality, but I could be convinced otherwise.

@ao-david
Copy link
Member

LGTM. Are you planning on adding a more user-friendly UI for this, or do you want to write an issue for this, and get someone else to tackle?
Also, I wonder whether it would be possible/useful to have site wide supression rules (although I think that this should be handled by bench rather than oceantv)

Could add a more user friendly UI for this, but also not sure how much it adds given that it's just an advanced admin feature that will hopefully be updated only rarely. Personally wouldn't even add the noise of an issue given it's low priority and triviality, but I could be convinced otherwise.

I think that we should see how we end up using it and if it becomes necessary I guess

@saxon-milton saxon-milton force-pushed the notification-suppression branch from ed3a265 to 7f34990 Compare May 2, 2025 04:33
This allows us to add notification rules through the broadcast page.
This means we can suppress notifications of a particular kind or
containing a particular string. The rules are in a JSON format:
{ "SuppressKinds" : ["kind1","kind2", ... ], "SuppressContaining": ["some str"] }
@saxon-milton saxon-milton force-pushed the notification-suppression branch from 7f34990 to eccc802 Compare May 2, 2025 04:35
@saxon-milton saxon-milton merged commit dc10dea into main May 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants