otv: add missing event handling for powerOffFailedEvent#568
Merged
saxon-milton merged 1 commit intomainfrom May 28, 2025
Merged
otv: add missing event handling for powerOffFailedEvent#568saxon-milton merged 1 commit intomainfrom
saxon-milton merged 1 commit intomainfrom
Conversation
saxon-milton
force-pushed
the
fix-hardware-power-off-failed-event
branch
from
da0d8e7 to
0d2fc18
Compare
trekhopton
approved these changes
May 19, 2025
ao-david
approved these changes
May 27, 2025
In the hardwareStopping state, if the poweringOff substate fails a hardwarePowerOffFailedEvent is emitted, but we weren't handling this. We need to handling this in the hardwareStopping state and then transition to hardwareFailed.
saxon-milton
force-pushed
the
fix-hardware-power-off-failed-event
branch
from
0d2fc18 to
79ceeaf
Compare
This was referenced Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the hardwareStopping state, if the poweringOff substate fails a hardwarePowerOffFailedEvent is emitted, but we weren't handling this. We need to handling this in the hardwareStopping state and then transition to hardwareFailed.