Merged
Conversation
This change creates a popover which shows a calibration card for the user to add the currently measured values which will allow for auto calibration to occur.
This change adds a handler which handles the calibration of voltage sensors
ao-david
requested review from
Breezethebluemaskman,
saxon-milton,
scruzin and
trekhopton
trekhopton
approved these changes
Jun 23, 2025
This change adds an exit button for the popover to allow the user to more easily cancel the calibration action.
ao-david
force-pushed
the
489-esp-calibration
branch
from
a38fd74 to
e67a10f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a feature to be able to calibrate the voltage sensors of a controller. This is done with a popover which makes it easy and separate to the rest of the devices form. This should make it easier to configure devices, and will also help towards keeping track of devices that are calibrated and those that aren't in the future.