Conversation
This change adds the auto-calibration functionality to the alarm variable. This calibrates the alarm voltage, and alarm recovery voltage whenever the battery voltage is calibrated.
ao-david
requested review from
Breezethebluemaskman,
saxon-milton,
scruzin and
trekhopton
Member
Author
|
This still needs to be tested. |
trekhopton
approved these changes
Jul 16, 2025
This change rounds the values calculated as alarm voltage and recovery to use integers instead as the netsender client may not support floats.
Member
Author
This has now been tested, and updated to use ints instead of floats. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the auto-calibration functionality to the alarm variable. This calibrates the alarm voltage, and alarm recovery voltage whenever the battery voltage is calibrated.
This also fixes an error, where calibrating voltages that are reading 0 returns an inf, or NaN result.