bench: add --testdata flag for standalone datastore seeding#721
Merged
trekhopton merged 3 commits intomainfrom Mar 18, 2026
Merged
bench: add --testdata flag for standalone datastore seeding#721trekhopton merged 3 commits intomainfrom
trekhopton merged 3 commits intomainfrom
Conversation
trekhopton
force-pushed
the
feature/test-data
branch
from
f5e00cf to
2d6a7f1
Compare
Done because we might want to add more so I added a number.
ao-david
approved these changes
Mar 18, 2026
Member
ao-david
left a comment
ao-david
left a comment
There was a problem hiding this comment.
Just review the site keys and names
| }, | ||
| { | ||
| "skey": 2, | ||
| "name": "Public Beach (No Perms)", |
Member
There was a problem hiding this comment.
You could make it really clear and say what perm the user should have
| "public": false | ||
| }, | ||
| { | ||
| "skey": 2, |
Member
There was a problem hiding this comment.
I think that this may be the same key as the sandbox site which has some functionality hardcoded to that SiteID
Done because skey 3 is special and for sandbox, so worth having as a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done because I would often check things on the production data since there wasn't enough populated data data and it was tedious to do it manually. Now we can populate the test data and test in standalone more thoroughly, which results in safer testing (not working with production data).