The 'RequiresUnreferencedCodeAttribute' should be internal

[prochnowc]

Describe the Bug

The 'RequiresUnreferencedCodeAttribute' should be internal. When targeting .NET 4.6.2 and using the Polyfill package this causes compile errors.

Steps to Reproduce

Create a project which targets .NET 4.6.2 and Reference Autofac and Polyfill.

using System;
using System.Diagnostics.CodeAnalysis;

[RequiresUnreferencedCode("Requires unreferenced code.")]		
public class Test
{
}

Expected Behavior

The code should compile.

Autofac: 8.3.0

[tillig]

@alistairjevans this got added like five years ago. Do you remember if there was a reason this one was public when the rest were internal?

[alistairjevans]

Afraid not; it does seem like it should be internal like the others.

[prochnowc]

It's common practice to include these attributes in your own assembly when targeting frameworks which do not include them.
But these should always be internal.

[tillig]

@prochnowc Thanks, we're aware of the practice and have done this for years, but sometimes there are reasons for things that are different. It felt like a good idea to check before electing to make a change and have something else break.

[prochnowc]

@tillig Do you mind if I contribute the PR for the change?

[tillig]

Sure, that'd be awesome.

[prochnowc]

@tillig Here you go.

[tillig]

I will cut a release as soon as I can; it appears there's something off about the build and I need to figure that out.

[tillig]

Published as v8.4.0.