Skip to content

Fix boxing in ResolveRequest.operator==()#1430

Merged
alistairjevans merged 1 commit intoautofac:developfrom
SergeiPavlov:ResolveRequest
Sep 21, 2024
Merged

Fix boxing in ResolveRequest.operator==()#1430
alistairjevans merged 1 commit intoautofac:developfrom
SergeiPavlov:ResolveRequest

Conversation

@SergeiPavlov
Copy link
Copy Markdown
Contributor

@SergeiPavlov SergeiPavlov commented Sep 20, 2024

ResolveRequest is Value type and calling Equals(object, object) in operator==() boxes arguments

But this operator is not used anyway.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (b222d0f) to head (59ad08f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1430      +/-   ##
===========================================
+ Coverage    78.60%   87.50%   +8.90%     
===========================================
  Files          200      200              
  Lines         5716     5716              
  Branches      1160     1160              
===========================================
+ Hits          4493     5002     +509     
- Misses         712      713       +1     
+ Partials       511        1     -510     
Flag Coverage Δ
87.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably added to conform to the 'implement equals on value types' analyzer requirement, despite not being needed. Thanks!

@alistairjevans alistairjevans merged commit ebc0386 into autofac:develop Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants