Conversation
vedhavyas
approved these changes
Jan 6, 2023
liuchengxu
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Substrate merged into our fork cleanly, so it is still on
subspace-v3branch.The biggest source of changes here is further upstream refactoring replacing
BlockIdwithBlock::Hashin various places.Another source of changes is
tracing_unboundedthat has second argument pointing to number of messages in flight after which warning will be printed. In most cases we expect just one message there, but due to upstream design decisions to no guarantee memory ordering there and usei64we can't really put a specific number on it deterministically, so I put100everywhere, please correct it if there is a place where we do expect those messages to be buffered and higher threshold is desired. See paritytech/substrate#12971 for details.Some notable upstream changes we'll likely want to leverage going forward:
frame_support::storage: AddStorageStreamIterparitytech/substrate#12721There are some fixes, including to canonicalization you're already aware of.
Code contributor checklist: