Skip to content

feat(repos): upgrade agnocast to 2.0.1#5977

Merged
youtalk merged 2 commits into
autowarefoundation:mainfrom
sykwer:upgrade-agnocast-2.0.1
Apr 4, 2025
Merged

feat(repos): upgrade agnocast to 2.0.1#5977
youtalk merged 2 commits into
autowarefoundation:mainfrom
sykwer:upgrade-agnocast-2.0.1

Conversation

@sykwer
Copy link
Copy Markdown
Member

@sykwer sykwer commented Apr 3, 2025

Description

https://github.com/tier4/agnocast/tree/2.0.1

See #5968 for the package release policy of agnocast.

How was this PR tested?

Notes for reviewers

We've discovered that due to the specifications of PPA, releasing a new version of agnocast-kmod or agnocast-heaphook causes the previous version to become unavailable, with no workaround. As a result, we'll be changing our release policy. Apologies for the lack of prior investigation into the PPA behavior.

We will provide separate packages for each major version—for example: agnocast-kmod-v1, agnocast-kmod-v2, agnocast-heaphook-v1, agnocast-heaphook-v2, and so on.

Effects on system behavior

None.

Signed-off-by: sykwer <sykwer@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sykwer sykwer marked this pull request as ready for review April 3, 2025 02:14
@sykwer sykwer requested review from Koichi98, atsushi421 and veqcc April 3, 2025 02:14
@sykwer sykwer self-assigned this Apr 3, 2025
@sykwer sykwer added the run:health-check Run health-check label Apr 3, 2025
Signed-off-by: sykwer <sykwer@gmail.com>
@youtalk
Copy link
Copy Markdown
Member

youtalk commented Apr 3, 2025

In terms of semantic versioning, moving from 1.0 to 2.0 means the major version is increasing. In other words, it indicates that the API is not backward compatible. It can’t be merged easily.

@sykwer
Copy link
Copy Markdown
Member Author

sykwer commented Apr 3, 2025

In terms of semantic versioning, moving from 1.0 to 2.0 means the major version is increasing. In other words, it indicates that the API is not backward compatible. It can’t be merged easily.

@youtalk

Some publicly exposed environment variable names have changed in a backward-incompatible way, so I made a major update. Currently, agnocast's public API is not used in Autoware, so I've confirmed that the major update has no actual impact. That said, would it be possible to upgrade?

@sykwer
Copy link
Copy Markdown
Member Author

sykwer commented Apr 3, 2025

This PR will fix #5974.

@sykwer sykwer added run:health-check Run health-check and removed run:health-check Run health-check labels Apr 3, 2025
@mitsudome-r
Copy link
Copy Markdown
Member

If the new version is compatible with the current Autoware, then I think we can upgrade it.

@mitsudome-r
Copy link
Copy Markdown
Member

We've discovered that due to the specifications of PPA, releasing a new version of agnocast-kmod or agnocast-heaphook causes the previous version to become unavailable, with no workaround. As a result, we'll be changing our release policy. Apologies for the lack of prior investigation into the PPA behavior.

We will provide separate packages for each major version—for example: agnocast-kmod-v1, agnocast-kmod-v2, agnocast-heaphook-v1, agnocast-heaphook-v2, and so on.

However, this action is really needed in the long run. We would like to make sure that Autoware's old tags still works even the new version is released from PPA.

@sykwer
Copy link
Copy Markdown
Member Author

sykwer commented Apr 3, 2025

However, this action is really needed in the long run. We would like to make sure that Autoware's old tags still works even the new version is released from PPA.

We'll deal with it soon

@sykwer sykwer closed this Apr 3, 2025
@sykwer sykwer reopened this Apr 3, 2025
Copy link
Copy Markdown
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just by glancing at the diff autowarefoundation/agnocast@1.0.2...2.0.1, I can see that it’s not just changes to environment variables—there are a lot of other modifications as well. Ideally, only the diffs necessary for the bug fix #5974 should be committed first, and then feature development should follow.

@sykwer Please make sure not to forget this approach going forward.

@youtalk
Copy link
Copy Markdown
Member

youtalk commented Apr 4, 2025

Since we can’t pass the setup-universe check unless we either revert the PRs #5930 #5917 or merge this one, I’ll go ahead and merge it.

@youtalk youtalk merged commit 565aed4 into autowarefoundation:main Apr 4, 2025
35 of 40 checks passed
sykwer added a commit to sykwer/autoware that referenced this pull request Apr 4, 2025
@sykwer sykwer mentioned this pull request Apr 4, 2025
sykwer added a commit to sykwer/autoware that referenced this pull request Apr 4, 2025
…)"

This reverts commit 565aed4.

Signed-off-by: sykwer <sykwer@gmail.com>
youtalk pushed a commit that referenced this pull request Apr 4, 2025
* Revert "feat(repos): upgrade agnocast to 2.0.1 (#5977)"

This reverts commit 565aed4.

Signed-off-by: sykwer <sykwer@gmail.com>

* Revert "fix(ansible): install linux kernel header before dkms installation (#5930)"

This reverts commit b9f39db.

Signed-off-by: sykwer <sykwer@gmail.com>

* revert and fix conflict

Signed-off-by: sykwer <sykwer@gmail.com>

---------

Signed-off-by: sykwer <sykwer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants