feat(repos): upgrade agnocast to 2.0.1#5977
Conversation
Signed-off-by: sykwer <sykwer@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: sykwer <sykwer@gmail.com>
|
In terms of semantic versioning, moving from 1.0 to 2.0 means the major version is increasing. In other words, it indicates that the API is not backward compatible. It can’t be merged easily. |
Some publicly exposed environment variable names have changed in a backward-incompatible way, so I made a major update. Currently, agnocast's public API is not used in Autoware, so I've confirmed that the major update has no actual impact. That said, would it be possible to upgrade? |
|
This PR will fix #5974. |
|
If the new version is compatible with the current Autoware, then I think we can upgrade it. |
However, this action is really needed in the long run. We would like to make sure that Autoware's old tags still works even the new version is released from PPA. |
We'll deal with it soon |
youtalk
left a comment
There was a problem hiding this comment.
Just by glancing at the diff autowarefoundation/agnocast@1.0.2...2.0.1, I can see that it’s not just changes to environment variables—there are a lot of other modifications as well. Ideally, only the diffs necessary for the bug fix #5974 should be committed first, and then feature development should follow.
@sykwer Please make sure not to forget this approach going forward.
…)" This reverts commit 565aed4.
…)" This reverts commit 565aed4. Signed-off-by: sykwer <sykwer@gmail.com>
* Revert "feat(repos): upgrade agnocast to 2.0.1 (#5977)" This reverts commit 565aed4. Signed-off-by: sykwer <sykwer@gmail.com> * Revert "fix(ansible): install linux kernel header before dkms installation (#5930)" This reverts commit b9f39db. Signed-off-by: sykwer <sykwer@gmail.com> * revert and fix conflict Signed-off-by: sykwer <sykwer@gmail.com> --------- Signed-off-by: sykwer <sykwer@gmail.com>
Description
https://github.com/tier4/agnocast/tree/2.0.1
See #5968 for the package release policy of agnocast.
How was this PR tested?
Notes for reviewers
We've discovered that due to the specifications of PPA, releasing a new version of agnocast-kmod or agnocast-heaphook causes the previous version to become unavailable, with no workaround. As a result, we'll be changing our release policy. Apologies for the lack of prior investigation into the PPA behavior.
We will provide separate packages for each major version—for example: agnocast-kmod-v1, agnocast-kmod-v2, agnocast-heaphook-v1, agnocast-heaphook-v2, and so on.
Effects on system behavior
None.