Skip to content

fix(ansible): spconv was not installed as part of the openadkit#6032

Merged
youtalk merged 2 commits into
autowarefoundation:mainfrom
knzo25:fix/openadkit_spconv
May 12, 2025
Merged

fix(ansible): spconv was not installed as part of the openadkit#6032
youtalk merged 2 commits into
autowarefoundation:mainfrom
knzo25:fix/openadkit_spconv

Conversation

@knzo25
Copy link
Copy Markdown
Contributor

@knzo25 knzo25 commented Apr 14, 2025

Description

spconv was added to the universe playbook but not the openadkit one

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Copy Markdown
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knzo25!
After image rebuild I can confirm libraries in container:

$ docker run --rm -it ghcr.io/autowarefoundation/autoware:universe-devel-cuda 
root@f1b1657c619a:/autoware# dpkg -l | grep cumm
ii  cumm                                              0.5.3                                   amd64        sparse convolution library
root@f1b1657c619a:/autoware# dpkg -l | grep spconv
ii  spconv                                            2.3.8                                   amd64        sparse convolution library

@knzo25 knzo25 marked this pull request as ready for review April 21, 2025 11:08
@knzo25 knzo25 added the run:health-check Run health-check label Apr 21, 2025
Copy link
Copy Markdown
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late notice. LGTM

@youtalk youtalk enabled auto-merge (squash) May 12, 2025 01:19
@youtalk youtalk merged commit f0b01ee into autowarefoundation:main May 12, 2025
15 of 17 checks passed
youtalk added a commit to youtalk/autoware that referenced this pull request May 14, 2025
* ci(docker-build-and-push.yaml): add `max-parallelism` option to restrict `docker build make` parallelism (autowarefoundation#6081)

* add utility-image arg

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* set commit hash

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* split update-docker-manifest

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* set-swap-space on cuda job

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add comment

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* set-swap-space on all jobs

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* set max-parallelism

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* Revert "set-swap-space on all jobs"

This reverts commit 4c321ae.

* Revert "set-swap-space on cuda job"

This reverts commit 034250c.

* remove swap

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* wip

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix precommit

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* revert

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix indent

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* decrease swap size

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* revert cuda

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* use default runner

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* remove swap

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* Update .github/workflows/docker-build-and-push.yaml

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(simulator.repos): major update tier4/scenario_simulator_v2 to 16.3.2 (autowarefoundation#6092)

Signed-off-by: github-actions <github-actions@github.com>

* chore: release 0.44.1 (autowarefoundation#6115)

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>

* feat(autoware.repos): minor update autowarefoundation/autoware_utils to 1.4.0 (autowarefoundation#6077)

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>

* ci(docker-build-and-push-cuda): push `autoware:universe-common-devel-cuda` image (autowarefoundation#6126)

add universe-common-devel-cuda images

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* ci(action.yaml): add `--shallow` option to `vcs import` (autowarefoundation#6127)

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(repos): update autoware.repos nebula driver version (autowarefoundation#6128)

update autoware.repos nebula driver version

update nebula driver version to implement new radar message

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix(ansible): spconv was not installed as part of the openadkit (autowarefoundation#6032)

fix: spconv was not installed as part of the openadkit

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(autoware.repos): minor update tier4/tier4_ad_api_adaptor to 0.43.0 (autowarefoundation#6131)

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>

* feat(autoware.repos): patch update autowarefoundation/autoware_launch to 0.44.1 (autowarefoundation#6136)

Signed-off-by: github-actions <github-actions@github.com>

* fix(ansible): correctly restore IPv6 disablement (autowarefoundation#6137)

* = 0 is OK

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* increase max-parallelism

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: Mete Fatih Cırıt <mfc@autoware.org>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Taekjin LEE <technolojin@gmail.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants