Skip to content

fix(ansible): rename plotjuggler-ros to plotjuggler#6153

Merged
mitsudome-r merged 3 commits into
autowarefoundation:mainfrom
rej55:fix/rename-plotjuggler
May 21, 2025
Merged

fix(ansible): rename plotjuggler-ros to plotjuggler#6153
mitsudome-r merged 3 commits into
autowarefoundation:mainfrom
rej55:fix/rename-plotjuggler

Conversation

@rej55
Copy link
Copy Markdown
Contributor

@rej55 rej55 commented May 19, 2025

Description

In package release for Humble Hawksbill 2025-05-16, ros-humble-plotjuggler-ros was removed.
In this PR, I changed the package name and add plotjuggler-ros-plugins to tools.repos.

How was this PR tested?

  • CI
  • Check on my local environment

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Fumiya Watanabe <fumiya.watanabe.44@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@rej55 rej55 changed the title fix: rename plotjuggler-ros to plotjuggler fix(ansible): rename plotjuggler-ros to plotjuggler May 19, 2025
@mitsudome-r mitsudome-r added the run:health-check Run health-check label May 19, 2025
Copy link
Copy Markdown
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passed.

@mitsudome-r
Copy link
Copy Markdown
Member

@rej55 Has anyone tested if any of the config files in autoware works without plotjuggler_ros package? (for example this one)

Signed-off-by: Fumiya Watanabe <fumiya.watanabe.44@gmail.com>
@rej55 rej55 requested review from mitsudome-r and xmfcx as code owners May 19, 2025 07:42
@rej55
Copy link
Copy Markdown
Contributor Author

rej55 commented May 19, 2025

@mitsudome-r Thank you for your comment.
It is not sufficient to install ros-humble-plotjuggler only, so I add plotjuggler-ros-plugins to tools.repos to build from source.
4b7584a

I checked it in my local environment.

@rej55
Copy link
Copy Markdown
Contributor Author

rej55 commented May 19, 2025

https://github.com/autowarefoundation/autoware/actions/runs/15107217677/job/42458368345?pr=6153 😢

@youtalk @mitsudome-r
Do you have any ideas to solve this problem?

ERROR: failed to solve: ResourceExhausted: failed to copy files: copy file range failed: no space left on device

@mitsudome-r
Copy link
Copy Markdown
Member

mitsudome-r commented May 19, 2025

We could try using 24.04 runner which has larger disk space.
Checking in https://github.com/autowarefoundation/autoware/actions/runs/15110345942

@rej55
Copy link
Copy Markdown
Contributor Author

rej55 commented May 20, 2025

@mitsudome-r @youtalk
Following workflow finished successfully. Thank you for trying.
https://github.com/autowarefoundation/autoware/actions/runs/15110345942

Is it okay to merge?

Comment thread tools.repos
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55
Copy link
Copy Markdown
Contributor Author

rej55 commented May 21, 2025

@mitsudome-r @youtalk
I think it is ready to merge.
Could you merge?

@mitsudome-r mitsudome-r merged commit 0e3c9f9 into autowarefoundation:main May 21, 2025
17 checks passed
@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented May 28, 2025

How did the version 2.1.3 compiled in humble?
It shouldn't be possible. It has breaking changes for humble to work with jazzy.

image

Maybe it wasn't tested?

Back when this PR was merged, main branch used to be able to compile but not 2.1.3.

I will switch the versions to humble compatible ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants