Skip to content

feat(docker): fix scenario-simulator and add readme for tool containers#6159

Merged
oguzkaganozt merged 11 commits into
mainfrom
fix/openadkit-scenario-simulator
Aug 7, 2025
Merged

feat(docker): fix scenario-simulator and add readme for tool containers#6159
oguzkaganozt merged 11 commits into
mainfrom
fix/openadkit-scenario-simulator

Conversation

@oguzkaganozt
Copy link
Copy Markdown
Contributor

@oguzkaganozt oguzkaganozt commented May 20, 2025

Description

Scenario-simulator container can now run out of the box with all required dependencies installed.

Extraction of rosdep dependencies put at the beggining in order to not miss already installed rosdep packages and xmlschema version set to 3.4.5

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@oguzkaganozt oguzkaganozt requested a review from mitsudome-r May 20, 2025 11:49
@oguzkaganozt oguzkaganozt self-assigned this May 20, 2025
@oguzkaganozt oguzkaganozt requested a review from youtalk as a code owner May 20, 2025 11:49
@oguzkaganozt oguzkaganozt added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels May 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@oguzkaganozt oguzkaganozt added the run:health-check Run health-check label May 20, 2025
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) May 20, 2025 13:45
@oguzkaganozt oguzkaganozt disabled auto-merge May 20, 2025 13:46
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) May 20, 2025 13:46
auto-merge was automatically disabled May 21, 2025 18:14

Pull request was closed

@oguzkaganozt oguzkaganozt reopened this May 22, 2025
@oguzkaganozt oguzkaganozt force-pushed the fix/openadkit-scenario-simulator branch from e5c232d to 6479e21 Compare May 22, 2025 07:13
@oguzkaganozt oguzkaganozt marked this pull request as draft May 22, 2025 07:34
@oguzkaganozt oguzkaganozt marked this pull request as ready for review May 23, 2025 13:29
@oguzkaganozt oguzkaganozt force-pushed the fix/openadkit-scenario-simulator branch from a497019 to cdcae7b Compare May 23, 2025 13:29
@oguzkaganozt
Copy link
Copy Markdown
Contributor Author

oguzkaganozt commented May 23, 2025

Please review @mitsudome-r @youtalk after this PR scenario-simulator container will work out-of-the-box

@oguzkaganozt oguzkaganozt force-pushed the fix/openadkit-scenario-simulator branch 2 times, most recently from dc6db71 to 583a1cf Compare May 26, 2025 13:42
@oguzkaganozt oguzkaganozt changed the title fix(docker): fix scenario-simulator missing packages feat(docker): fix scenario-simulator and add readme for tool containers May 28, 2025
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt force-pushed the fix/openadkit-scenario-simulator branch from 20095a8 to 2b7feff Compare July 3, 2025 12:12
@mitsudome-r
Copy link
Copy Markdown
Member

@oguzkaganozt It looks okay to me for scenario-simulator update. Could you resolve conflicts for visualizer enterypoint.sh?

oguzkaganozt and others added 4 commits August 1, 2025 14:44
.
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
.
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
oguzkaganozt and others added 4 commits August 1, 2025 15:07
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
.
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt
Copy link
Copy Markdown
Contributor Author

@oguzkaganozt It looks okay to me for scenario-simulator update. Could you resolve conflicts for visualizer enterypoint.sh?

@mitsudome-r fixed, please review again.

@oguzkaganozt oguzkaganozt enabled auto-merge (squash) August 7, 2025 13:23
@oguzkaganozt oguzkaganozt merged commit 2faa920 into main Aug 7, 2025
16 of 17 checks passed
@oguzkaganozt oguzkaganozt deleted the fix/openadkit-scenario-simulator branch August 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants