Skip to content

refactor: move *.repos under repositories/#6646

Merged
xmfcx merged 4 commits into
mainfrom
refactor/move-repos
Dec 25, 2025
Merged

refactor: move *.repos under repositories/#6646
xmfcx merged 4 commits into
mainfrom
refactor/move-repos

Conversation

@xmfcx
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx commented Dec 16, 2025

Description

Related discussions:

Changes

To clean up the root directory of autoware repository, this PR moves the .repos files under repositories/ folder.
Also adds src/README.md do improve newcomer experience.

Related Issue:

Related PRs:

How was this PR tested?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r
Copy link
Copy Markdown
Member

For this PR, I would like to change to post the discussion first and make sure that no one disagrees with the change.
This isn't a big change in terms of code but has relatively large influence to users experience since everyone runs vcs import when they use autoware.

@xmfcx xmfcx force-pushed the refactor/move-repos branch from 287178a to 1aa7346 Compare December 17, 2025 08:17
@xmfcx xmfcx marked this pull request as ready for review December 17, 2025 08:18
@xmfcx xmfcx added the run:health-check Run health-check label Dec 17, 2025
@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Dec 17, 2025

Made the announcement post:

@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Dec 17, 2025

As we are adding src/README.md file, src/ is no longer under the root .gitignore.
From now on, src folder will always exists.

The added .gitignore under src/ will ignore everything in it except the .gitignore file itself and the README.md to keep the behavior same.

It required a4b9310 change (adding -p for mkdir src since the directory already exists).

@mitsudome-r
Copy link
Copy Markdown
Member

Since it has modification in .webauto-ci.yaml, I'm also testing in WebAuto Evaluator, but it seems like it is failing. I will check with the evaluator team if it has any assumptions with the path https://evaluation.ci.tier4.jp/evaluation/reports/e1d4be2c-ac80-5688-82b2-7ceafaf738cb/builds/1add11e2-721d-5f30-86e3-39a14124eac5?project_id=awf

@paulsohn
Copy link
Copy Markdown
Collaborator

Adding readme for src/ is fine. While I personally agree with repositories/ directory, I don't feel like we have discussed over this properly. We could have separate PR for this.

@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Dec 20, 2025

@paulsohn the new readme file references ../repositories/ folder quite a lot so it made sense to add them together.

This PR title is refactor: move *.repos under repositories/ if anything can be separated out, it is adding the readme.
But since the readme is going to change with this pr too, I found it unnecessary to do these in 2 steps.

We posted an announcement/discussion post and promoted in discord too.
I think the change will happen after about a week after the announcement with current pace.

Feel free to add your opinions/inputs.

@xmfcx xmfcx force-pushed the refactor/move-repos branch from a4b9310 to 407dcc2 Compare December 22, 2025 16:30
@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Dec 23, 2025

Running scenario evaluator for this: https://evaluation.ci.tier4.jp/evaluation/reports/6670d2de-d8ca-5cdb-9c97-eaee32dae213?project_id=awf

image

I did a clean build.

@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Dec 23, 2025

https://evaluation.ci.tier4.jp/evaluation/reports/6670d2de-d8ca-5cdb-9c97-eaee32dae213/builds/36268484-db74-5a48-bf47-320010f5a8bc?project_id=awf this is failing.

It pulls everything fine but attempts to upload a non-existent file.

$ vcs export --exact -n src > /var/lib/webauto-ci/RrG5vu/vcs/.tmp-vcs.repos.exact
$ yq eval-all '. as $item ireduce ({}; . * $item)' repositories/autoware.repos repositories/simulator.repos /var/lib/webauto-ci/RrG5vu/vcs/.tmp-vcs.repos.exact > /var/lib/webauto-ci/RrG5vu/vcs/vcs.repos.exact
[2025-12-23T09:04:21.424Z] (Fetch source) Uploading the exactly repositories file...
/usr/bin/bash: line 1: /var/lib/webauto-ci/RrG5vu/asset/vcstool/repos/repositories/autoware.repos: No such file or directory
[2025-12-23T09:04:21.545Z] (Fetch source) Error occurs in the phase
[2025-12-23T09:04:21.648Z] Build failed.

I don't see anything wrong in the

vcstool:
repositories_files:
- repositories/autoware.repos
- repositories/simulator.repos

Could someone from the web.auto team help?

Here are the uploaded files from the build:

So it was able to upload the combined frozen repos file.

But this line afterwards failed:

/usr/bin/bash: line 1: /var/lib/webauto-ci/RrG5vu/asset/vcstool/repos/repositories/autoware.repos: No such file or directory

Not sure what it is doing.

@xmfcx xmfcx force-pushed the refactor/move-repos branch from 407dcc2 to fe83258 Compare December 23, 2025 10:54
xmfcx and others added 4 commits December 23, 2025 16:56
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx force-pushed the refactor/move-repos branch from fe83258 to fdc913f Compare December 23, 2025 13:57
@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Dec 24, 2025

web.auto team fixed the issue.

https://evaluation.ci.tier4.jp/evaluation/reports/c89e57ed-d598-5b65-9892-148a6270ea9f?project_id=awf

image

Successful ✅

@mitsudome-r could you review?

@xmfcx xmfcx merged commit 7296f92 into main Dec 25, 2025
15 of 17 checks passed
@xmfcx xmfcx deleted the refactor/move-repos branch December 25, 2025 11:20
xmfcx added a commit to xmfcx/autoware that referenced this pull request Mar 20, 2026
…` in jazzy-cuda job

The `docker-build-and-push-jazzy-cuda` job was missed during
7296f92 (refactor: move *.repos under repositories/ (autowarefoundation#6646)).

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
mitsudome-r pushed a commit that referenced this pull request Mar 21, 2026
…` in jazzy-cuda job (#6923)

The `docker-build-and-push-jazzy-cuda` job was missed during
7296f92 (refactor: move *.repos under repositories/ (#6646)).

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants