feat: autoware system designer#6739
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
First of all, I like to appreciate your great work. I have some opinions for the detail:
More context for (2): as a former user of Bazel, I don't really like the misalignment between build stage and launch stage requirements. For example, v0.3.x nebula supports depending on only necessary components, but our sample sensor kits cannot enjoy this improvement, and our Still work in progress, but I want to share my milestones here. I am
cc @mojomex |
Some plugins and libraries are used in the code, but not from the launcher. So we need a place for people to write the dependencies on |
|
@Owen-Liuyuxuan Yes, I think it will really take lots of efforts and don't know even if it's possible for now. In the meantime it would be great if we have something directly in launcher, not packages.xml: <build_depends>
<build_depend>dep1</build_depend>
<build_depend>dep2</build_depend>
</build_depends>... AND fallback to package.xml build_depend list if such entry does not exist. For now I'm just daydreaming on milestone 2, but it seems worthy to discuss. |
|
@paulsohn @Owen-Liuyuxuan |
2021ac5 to
eea0476
Compare
|
I would like to check this PR
|
|
@technolojin If we are going to add under core/ directory, we should add them to autoware.repos. |
eea0476 to
354008a
Compare
|
@mitsudome-r when other reviews are finished, I will bring back to open with updates. |
354008a to
403d654
Compare
403d654 to
d1a85ba
Compare
|
autowarefoundation/autoware_launch#1751 |
mitsudome-r
left a comment
There was a problem hiding this comment.
Build on arm was failing due to communication issue to runner so I'm rerunning the test just in case.
|
I added build test to the autoware_system_designer repository autowarefoundation/autoware_system_designer#34 |
|
@mitsudome-r This is unrelated to the PR. The
The Root cause:
|
…y configuration Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> feat(repositories): update repository URLs and versions for autoware components Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> fix(repositories): update repository URLs to point to tier4 organization Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> fix(repositories): update autoware_core URL and version to point to tier4 organization Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> feat(repositories): add core/autoware_system_designer repository to nightly configuration Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> fix(repositories): update autoware_system_designer URL to point to autowarefoundation organization Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> back to origin repos/branches Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> remove duplicated nebula source Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> remove duplicated system designer Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> a
47c09d9 to
5e46b42
Compare
|
@technolojin Is there a reason why this was not added to autoware.repos too? Failed but not sure if related, still investigating. But in general, we don't want to have a repo to only be in nightly.
|
|
@xmfcx I confirmed the issue about cmake macros refers hard-coded paths. autowarefoundation/autoware_system_designer#46 The root cause is fixed in v0.3.2 autowarefoundation/autoware_system_designer#48 and it would be introduced to the autoware #7010 can you review the version update PR #7010 ? then We may can bring back the autoware_launch PR autowarefoundation/autoware_launch#1814 |

Description
DISCUSSION https://github.com/orgs/autowarefoundation/discussions/6760
ISSUE #6793
autoware system designer: https://github.com/autowarefoundation/autoware_system_designer
autoware_system_design_formatHow was this PR tested?
build
launch
logging simulator
AWSIM
planning simulator
visualization
# visualization google-chrome /your/workspace/install/systems.html