fix(ansible): simplify git-lfs installation#6834
Merged
Merged
Conversation
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Git LFS setup by replacing the
community.general.git_configcheck with a directgit lfs installcall. Thegit_configmodule now requires anameargument even withlist_all: true, which made it fail the pre-commit ansible lint check.Since
git lfs installis idempotent (safely rewrites the same config and hooks every run), the conditional check was unnecessary complexity. Also changedstate: latesttostate: presentto avoid unintended upgrades on every run.The error was this (running
pre-commit run -a --config .pre-commit-config-ansible.yaml):How was this PR tested?
Ran the playbook on a fresh machine and on a machine with Git LFS already configured. Verified
git lfs envshows correct config in both cases. Confirmed ansible-lint passes cleanly.https://github.com/autowarefoundation/autoware/actions/runs/22242355408/job/64348702771?pr=6834#step:5:96 ✅