Skip to content

fix(ci): sanitize branch name in docker buildcache tags#6954

Merged
xmfcx merged 1 commit into
mainfrom
fix/ci-sanitize-buildcache-ref-name
Mar 27, 2026
Merged

fix(ci): sanitize branch name in docker buildcache tags#6954
xmfcx merged 1 commit into
mainfrom
fix/ci-sanitize-buildcache-ref-name

Conversation

@xmfcx
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx commented Mar 27, 2026

Why

Docker tags cannot contain /. Branches using the type/description naming convention (e.g. refactor/ci-pass-rosdistro-instead-of-env) produce invalid registry cache references, causing buildx bake to fail with invalid reference format. This only affects non-main branches, making it appear flaky.


Test plan

Replace slashes in github.ref_name with dashes before using it in
Docker registry cache tags, which cannot contain slashes.

Fixes #6953

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx self-assigned this Mar 27, 2026
@github-actions
Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx requested a review from mitsudome-r March 27, 2026 20:42
@youtalk youtalk added the run:health-check Run health-check label Mar 27, 2026
Copy link
Copy Markdown
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the problem and thank you for your fix.

@xmfcx
Copy link
Copy Markdown
Contributor Author

xmfcx commented Mar 27, 2026

Thanks for the review!

The verification run did not fail at the first 3 minutes so I'll go ahead and merge it. I have another PR that is waiting, it will also test it further.

@xmfcx xmfcx merged commit 56bacbf into main Mar 27, 2026
29 of 30 checks passed
@xmfcx xmfcx deleted the fix/ci-sanitize-buildcache-ref-name branch March 27, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants