Get config stack var after node simplification#1227
Open
kazarmy wants to merge 1 commit intoavast:masterfrom
Open
Get config stack var after node simplification#1227kazarmy wants to merge 1 commit intoavast:masterfrom
kazarmy wants to merge 1 commit intoavast:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to get config stack variables before node simplification, because the stack offset obtained from the node can change* after simplification, perhaps through arithmetic evaluation. This pr makes it so that debug and config stack variables are only obtained after node simplification.
*Confirmed via tracing.