Conversation
added 2 commits
April 20, 2020 15:30
+ Added support for heuristic YARA rules
s3rvac
changed the title
s3rvac
requested changes
Apr 20, 2020
Member
s3rvac
left a comment
s3rvac
left a comment
There was a problem hiding this comment.
The build on Linux&macoOS fails, so I was unable to run the tests. Could you please fix the build (see my remark below)? I will then run all the tests.
Member
|
Thank you for the fixes. Let's run TeamCity tests. |
s3rvac
approved these changes
Apr 21, 2020
Member
s3rvac
left a comment
s3rvac
left a comment
There was a problem hiding this comment.
All the tests pass, code LGTM, so I am approving the PR and merging 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.