You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ladislav-zezula Code and tests look ok, but features.windrivers.Test regression tests is failing across all the architectures. I hoped it is some small detail, but it looks like after this change, there are major differences in the underlying data. I'm adding outputs before and after the change. There is much less code in the output C after the change. In .dsm files, we can see that before the change, there were much more data that got decoded into instructions. After the change, these bytes are zero and we don't get instruction, functions, etc.
I'm not sure if this is ok - i.e. it was bad before, or if your changes have some bad side effects. Can you please have a look - you know more about it than I do. If you won't know right away, we may investigate it together. out.zip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.