Add check that the resource file offset is valid#982
Merged
PeterMatula merged 5 commits intoavast:masterfrom Aug 25, 2021
Merged
Add check that the resource file offset is valid#982PeterMatula merged 5 commits intoavast:masterfrom
PeterMatula merged 5 commits intoavast:masterfrom
Conversation
Member
Good point, could this be please incorporated into these changes? |
Member
Author
|
I've added a flag that represents the offset validity, so invalid offsets are not exported to the output at all. |
metthal
suggested changes
Aug 10, 2021
Collaborator
|
lets run TC tests |
PeterMatula
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses partially #963
Add check that the file offset of a Resource is actually somewhere inside section physical data
Sample that has such invalid offsets:
8a8154c36977c3f47a65c329a6dd93c58b8aff6050a4a748f4c610310daf0d8bIf this fix is wanted, there are few things to consider: