Fix of .NET analysis differences#997
Merged
PeterMatula merged 15 commits intoavast:masterfrom Aug 30, 2021
Merged
Conversation
Member
|
Is this ready for merge? |
Member
Author
|
I'll add some new tests and correct the existing ones before merging |
Collaborator
|
lets run TC tests |
PeterMatula
reviewed
Aug 25, 2021
Collaborator
PeterMatula
left a comment
There was a problem hiding this comment.
As far as I can tell, it looks ok. Only a few questions.
Maybe @metthal would like to have a look as well.
metthal
suggested changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing several .NET parsing differences and bugs: