Skip to content

Fix: ChatResponseUpdate missing LoadDuration and TotalDuration metrics#369

Merged
awaescher merged 5 commits intoawaescher:mainfrom
JerryJian:fix-streaming-metrics
Mar 4, 2026
Merged

Fix: ChatResponseUpdate missing LoadDuration and TotalDuration metrics#369
awaescher merged 5 commits intoawaescher:mainfrom
JerryJian:fix-streaming-metrics

Conversation

@JerryJian
Copy link
Copy Markdown

@JerryJian JerryJian commented Mar 4, 2026

Add AdditionalProperties to ChatResponseUpdate when received ChatDoneResponseStream from ollama.

Related Issue

Fixes #368

@awaescher
Copy link
Copy Markdown
Owner

This is a great find, thank you. Would you mind adding a test in AbstractionMapperTests?

@JerryJian
Copy link
Copy Markdown
Author

Hi @awaescher
I've just pushed a new commit adding a test case: AbstractionMapperTests.ToChatResponseUpdateMethod.Maps_Performance_Metrics_To_AdditionalProperties.

@awaescher
Copy link
Copy Markdown
Owner

Very nice, thanks again for your contribution!

@awaescher awaescher merged commit ab863ac into awaescher:main Mar 4, 2026
1 check passed
@JerryJian JerryJian deleted the fix-streaming-metrics branch March 4, 2026 07:58
This was referenced Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetStreamingResponseAsync: ChatResponseUpdate missing LoadDuration and TotalDuration metrics

2 participants