Skip to content

feat: Add support for loggingConfig field in Function #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ack-prow merged 1 commit into from
May 12, 2025
Merged

feat: Add support for loggingConfig field in Function #170

ack-prow merged 1 commit into from
May 12, 2025

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented May 9, 2025

Issue #2122

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 May 9, 2025 17:43
@ack-prow ack-prow bot added the approved label May 9, 2025
@ack-prow
Copy link

ack-prow bot commented May 9, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lambda-verify-attribution 04fb54c link false /test lambda-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rushmash91
rushmash91 approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@rushmash91 rushmash91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @michaelhtm !

generator.yaml
- CreateFunctionOutput.RuntimeVersionConfig
- CreateFunctionOutput.LoggingConfig
# - CreateFunctionOutput.LoggingConfig
- CreateFunctionUrlConfigInput.InvokeMode
Copy link
Contributor

@rushmash91 rushmash91 May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: were these ignored as part of Gov2 earlier?

Copy link
Member Author

@michaelhtm michaelhtm May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goV2..

@rushmash91
Copy link
Contributor

rushmash91 commented May 12, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@ack-prow
Copy link

ack-prow bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [knottnt,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 0f2cb82 into aws-controllers-k8s:main May 12, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knottnt knottnt knottnt approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

+1 more reviewer

@rushmash91 rushmash91 rushmash91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rushmash91 rushmash91

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelhtm @rushmash91 @knottnt