Update manual sample app with OTel Python propagator package#38
Merged
NathanielRN merged 1 commit intoaws-observability:mainfrom Oct 12, 2021
Conversation
NathanielRN
force-pushed
the
update-manual-app-for-propagator-package
branch
from
7b8ed06 to
7c000b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Taking in the changes from upstream:
opentelemetry-propagators-awspackage open-telemetry/opentelemetry-python-contrib#720These changes were done to split the propagator into its own package. This was necessary for it to not depend on the
opentelemetry-sdkpackage. It cannot depend on this because ourAwsLambdaInstrumentorpackage will depend on the propagator and instrumentation should only depend on theopentelemetry-apipackage.