Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cli/aws/agentcore-control.ts
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ export interface GetEvaluatorResult {
llmAsAJudge?: GetEvaluatorLlmConfig;
codeBased?: GetEvaluatorCodeBasedConfig;
};
kmsKeyArn?: string;
tags?: Record<string, string>;
}

Expand Down Expand Up @@ -541,6 +542,7 @@ export async function getEvaluator(options: GetEvaluatorOptions): Promise<GetEva
status: response.status ?? 'UNKNOWN',
description: response.description,
evaluatorConfig,
kmsKeyArn: (response as unknown as Record<string, unknown>).kmsKeyArn as string | undefined,
tags,
};
}
Expand Down
43 changes: 43 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,49 @@ describe('toEvaluatorSpec', () => {

expect(result.tags).toBeUndefined();
});

it('forwards kmsKeyArn when present', () => {
const detail: GetEvaluatorResult = {
evaluatorId: 'eval-kms',
evaluatorArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-kms',
evaluatorName: 'kms_eval',
level: 'SESSION',
status: 'ACTIVE',
evaluatorConfig: {
llmAsAJudge: {
model: 'anthropic.claude-3-5-sonnet-20241022-v2:0',
instructions: 'Evaluate',
ratingScale: { numerical: [{ value: 1, label: 'Low', definition: 'Low' }] },
},
},
kmsKeyArn: 'arn:aws:kms:us-west-2:123456789012:key/12345678-1234-1234-1234-123456789012',
};

const result = toEvaluatorSpec(detail, 'kms_eval');

expect(result.kmsKeyArn).toBe('arn:aws:kms:us-west-2:123456789012:key/12345678-1234-1234-1234-123456789012');
});

it('omits kmsKeyArn when not present', () => {
const detail: GetEvaluatorResult = {
evaluatorId: 'eval-no-kms',
evaluatorArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-no-kms',
evaluatorName: 'no_kms_eval',
level: 'SESSION',
status: 'ACTIVE',
evaluatorConfig: {
llmAsAJudge: {
model: 'anthropic.claude-3-5-sonnet-20241022-v2:0',
instructions: 'Evaluate',
ratingScale: { numerical: [{ value: 1, label: 'Low', definition: 'Low' }] },
},
},
};

const result = toEvaluatorSpec(detail, 'no_kms_eval');

expect(result.kmsKeyArn).toBeUndefined();
});
});

// ============================================================================
Expand Down
1 change: 1 addition & 0 deletions src/cli/commands/import/import-evaluator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export function toEvaluatorSpec(detail: GetEvaluatorResult, localName: string):
level,
...(detail.description && { description: detail.description }),
config,
...(detail.kmsKeyArn && { kmsKeyArn: detail.kmsKeyArn }),
...(detail.tags && Object.keys(detail.tags).length > 0 && { tags: detail.tags }),
};
}
Expand Down
5 changes: 5 additions & 0 deletions src/cli/primitives/EvaluatorPrimitive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export interface AddEvaluatorOptions {
level: EvaluationLevel;
description?: string;
config: EvaluatorConfig;
kmsKeyArn?: string;
}

export type RemovableEvaluator = RemovableResource;
Expand Down Expand Up @@ -182,6 +183,7 @@ export class EvaluatorPrimitive extends BasePrimitive<AddEvaluatorOptions, Remov
'--config <path>',
'Path to evaluator config JSON file (overrides --model, --instructions, --rating-scale) [non-interactive]'
)
.option('--kms-key-arn <arn>', 'KMS key ARN for evaluator encryption (optional)')
.option('--json', 'Output as JSON [non-interactive]')
.action(
async (cliOptions: {
Expand All @@ -194,6 +196,7 @@ export class EvaluatorPrimitive extends BasePrimitive<AddEvaluatorOptions, Remov
lambdaArn?: string;
timeout?: string;
config?: string;
kmsKeyArn?: string;
json?: boolean;
}) => {
try {
Expand Down Expand Up @@ -296,6 +299,7 @@ export class EvaluatorPrimitive extends BasePrimitive<AddEvaluatorOptions, Remov
name: cliOptions.name!,
level: levelResult.data!,
config: configJson,
kmsKeyArn: cliOptions.kmsKeyArn,
});

if (cliOptions.json) {
Expand Down Expand Up @@ -385,6 +389,7 @@ export class EvaluatorPrimitive extends BasePrimitive<AddEvaluatorOptions, Remov
level: options.level,
...(options.description && { description: options.description }),
config: options.config,
...(options.kmsKeyArn && { kmsKeyArn: options.kmsKeyArn }),
};

project.evaluators.push(evaluator);
Expand Down
2 changes: 2 additions & 0 deletions src/cli/tui/hooks/useCreateEvaluator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ interface CreateEvaluatorConfig {
name: string;
level: string;
config: EvaluatorConfig;
kmsKeyArn?: string;
}

export function useCreateEvaluator() {
Expand All @@ -20,6 +21,7 @@ export function useCreateEvaluator() {
name: config.name,
level: config.level as 'SESSION' | 'TRACE' | 'TOOL_CALL',
config: config.config,
kmsKeyArn: config.kmsKeyArn,
});
if (!addResult.success) {
throw new Error(addResult.error ?? 'Failed to create evaluator');
Expand Down
19 changes: 19 additions & 0 deletions src/cli/tui/screens/evaluator/AddEvaluatorScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export function AddEvaluatorScreen({ onComplete, onExit, existingEvaluatorNames
const isRatingScaleCustomStep = wizard.step === 'ratingScale-custom';
const isLambdaArnStep = wizard.step === 'lambda-arn';
const isTimeoutStep = wizard.step === 'timeout';
const isKmsKeyArnStep = wizard.step === 'kms-key-arn';
const isConfirmStep = wizard.step === 'confirm';

const evaluatorTypeNav = useListNavigation({
Expand Down Expand Up @@ -163,6 +164,8 @@ export function AddEvaluatorScreen({ onComplete, onExit, existingEvaluatorNames

// Build confirm fields based on evaluator type
const confirmFields = useMemo(() => {
const kmsField = wizard.config.kmsKeyArn ? [{ label: 'KMS Key ARN', value: wizard.config.kmsKeyArn }] : [];

if (wizard.evaluatorType === 'llm-as-a-judge') {
const llm = wizard.config.config.llmAsAJudge!;
return [
Expand All @@ -175,6 +178,7 @@ export function AddEvaluatorScreen({ onComplete, onExit, existingEvaluatorNames
value: llm.instructions.length > 60 ? llm.instructions.slice(0, 60) + '...' : llm.instructions,
},
{ label: 'Rating Scale', value: formatRatingScale(llm.ratingScale) },
...kmsField,
];
}

Expand All @@ -187,6 +191,7 @@ export function AddEvaluatorScreen({ onComplete, onExit, existingEvaluatorNames
{ label: 'Code', value: managed.codeLocation },
{ label: 'Entrypoint', value: managed.entrypoint },
{ label: 'Timeout', value: `${managed.timeoutSeconds}s` },
...kmsField,
];
}

Expand All @@ -197,6 +202,7 @@ export function AddEvaluatorScreen({ onComplete, onExit, existingEvaluatorNames
{ label: 'Name', value: wizard.config.name },
{ label: 'Level', value: wizard.config.level },
{ label: 'Lambda ARN', value: external.lambdaArn },
...kmsField,
];
}, [wizard.evaluatorType, wizard.codeBasedType, wizard.config]);

Expand Down Expand Up @@ -374,6 +380,19 @@ export function AddEvaluatorScreen({ onComplete, onExit, existingEvaluatorNames
/>
)}

{isKmsKeyArnStep && (
<TextInput
key="kms-key-arn"
prompt="KMS key ARN for encryption (optional, press Enter to skip)"
initialValue=""
onSubmit={wizard.setKmsKeyArn}
onCancel={() => wizard.goBack()}
customValidation={value =>
value === '' || /^arn:[^:]+:kms:[a-z0-9-]+:\d{12}:key\/.+$/.test(value) || 'Must be a valid KMS key ARN'
}
/>
)}

{isConfirmStep && <ConfirmReview fields={confirmFields} />}
</Panel>
</Screen>
Expand Down
3 changes: 3 additions & 0 deletions src/cli/tui/screens/evaluator/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ export type AddEvaluatorStep =
| 'ratingScale-custom'
| 'lambda-arn'
| 'timeout'
| 'kms-key-arn'
| 'confirm';

export interface AddEvaluatorConfig {
name: string;
level: EvaluationLevel;
config: EvaluatorConfig;
kmsKeyArn?: string;
}

export const EVALUATOR_STEP_LABELS: Record<AddEvaluatorStep, string> = {
Expand All @@ -41,6 +43,7 @@ export const EVALUATOR_STEP_LABELS: Record<AddEvaluatorStep, string> = {
'ratingScale-custom': 'Scale',
'lambda-arn': 'Lambda',
timeout: 'Timeout',
'kms-key-arn': 'KMS Key',
confirm: 'Confirm',
};

Expand Down
21 changes: 20 additions & 1 deletion src/cli/tui/screens/evaluator/useAddEvaluatorWizard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const LLM_STEPS: AddEvaluatorStep[] = [
'model',
'instructions',
'ratingScale',
'kms-key-arn',
'confirm',
];
const CODE_MANAGED_STEPS: AddEvaluatorStep[] = [
Expand All @@ -30,6 +31,7 @@ const CODE_MANAGED_STEPS: AddEvaluatorStep[] = [
'name',
'level',
'timeout',
'kms-key-arn',
'confirm',
];
const CODE_EXTERNAL_STEPS: AddEvaluatorStep[] = [
Expand All @@ -38,6 +40,7 @@ const CODE_EXTERNAL_STEPS: AddEvaluatorStep[] = [
'name',
'level',
'lambda-arn',
'kms-key-arn',
'confirm',
];

Expand Down Expand Up @@ -80,6 +83,7 @@ export function useAddEvaluatorWizard() {
const [lambdaArn, setLambdaArnState] = useState('');
const [timeout, setTimeoutState] = useState(DEFAULT_CODE_TIMEOUT);
const [customRatingScaleType, setCustomRatingScaleType] = useState<CustomRatingScaleType>('numerical');
const [kmsKeyArn, setKmsKeyArnState] = useState('');
const [step, setStep] = useState<AddEvaluatorStep>('evaluator-type');

const steps = useMemo(() => getSteps(evaluatorType, codeBasedType), [evaluatorType, codeBasedType]);
Expand Down Expand Up @@ -109,11 +113,13 @@ export function useAddEvaluatorWizard() {

// Build the final config based on current state
const config: AddEvaluatorConfig = useMemo(() => {
const kms = kmsKeyArn || undefined;
if (evaluatorType === 'llm-as-a-judge') {
return {
name,
level,
config: { llmAsAJudge: llmConfig },
...(kms && { kmsKeyArn: kms }),
};
}

Expand All @@ -126,6 +132,7 @@ export function useAddEvaluatorWizard() {
external: { lambdaArn },
},
},
...(kms && { kmsKeyArn: kms }),
};
}

Expand All @@ -143,8 +150,9 @@ export function useAddEvaluatorWizard() {
},
},
},
...(kms && { kmsKeyArn: kms }),
};
}, [evaluatorType, codeBasedType, name, level, llmConfig, lambdaArn, timeout]);
}, [evaluatorType, codeBasedType, name, level, llmConfig, lambdaArn, timeout, kmsKeyArn]);

const selectEvaluatorType = useCallback((type: EvaluatorTypeId) => {
setEvaluatorType(type);
Expand Down Expand Up @@ -256,6 +264,15 @@ export function useAddEvaluatorWizard() {
[nextStep]
);

const setKmsKeyArn = useCallback(
(arn: string) => {
setKmsKeyArnState(arn);
const next = nextStep('kms-key-arn');
if (next) setStep(next);
},
[nextStep]
);

const reset = useCallback(() => {
setEvaluatorType('code-based');
setCodeBasedType('managed');
Expand All @@ -264,6 +281,7 @@ export function useAddEvaluatorWizard() {
setLlmConfig(getDefaultLlmConfig().llmAsAJudge!);
setLambdaArnState('');
setTimeoutState(DEFAULT_CODE_TIMEOUT);
setKmsKeyArnState('');
setStep('evaluator-type');
}, []);

Expand All @@ -288,6 +306,7 @@ export function useAddEvaluatorWizard() {
setCustomRatingScale,
setLambdaArn,
setTimeout,
setKmsKeyArn,
reset,
};
}
1 change: 1 addition & 0 deletions src/schema/schemas/agentcore-project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export const EvaluatorSchema = z.object({
level: EvaluationLevelSchema,
description: z.string().optional(),
config: EvaluatorConfigSchema,
kmsKeyArn: z.string().optional(),
tags: TagsSchema.optional(),
});

Expand Down
Loading