[Explored Related] Add platform type for Container Insights in EKS#1638
Merged
[Explored Related] Add platform type for Container Insights in EKS#1638
Conversation
musa-asad
approved these changes
Apr 7, 2025
nathalapooja
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The CWLogs team is unable to build an entire "Entity" object for ContainerInsights since metrics don't indicate whether they're running on EKS or native K8s, which is needed for key attributes (e.g. the Environment). Without this, telemetry cannot be correlated for ContainerInsights metrics making customers lose out on the Explore Related experience for these metrics.
We have EKS detection logic in the CloudWatch Agent. We want to invoke this in the Entity Processor translation logic to set the platform type for Entity. Then, we want the Entity Processor to process this into the resource attributes so that it becomes present in EMF logs.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit Tests.
Sample Output
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint