Merged
Conversation
movence
approved these changes
May 14, 2025
jefchien
approved these changes
May 14, 2025
Contributor
jefchien
left a comment
jefchien
left a comment
There was a problem hiding this comment.
nit: It seems like we're consistently missing
github.com/amazon-contributing/opentelemetry-collector-contrib/override/aws v0.0.0-20241216205413-8e059f1441db // indirect
Isn't a problem because we don't change it, but we might want to add a replace for it as well.
lisguo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Syncing go.mod and go.sum with changes in our otel contrib repo: https://github.com/amazon-contributing/opentelemetry-collector-contrib
Syncs from this commit: amazon-contributing/opentelemetry-collector-contrib@702a24c
Diff: amazon-contributing/opentelemetry-collector-contrib@060e328...702a24c
Description of changes
Changed all go.mod hashes pointing to the contrib repo to
aws-cwa-devand rango mod tidyLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
go mod tidy
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint