Add potential metric capitalization panic recovery for ApplicationSignals processor#1702
Closed
Add potential metric capitalization panic recovery for ApplicationSignals processor#1702
Conversation
bjrara
approved these changes
May 23, 2025
This was referenced May 24, 2025
thpierce
pushed a commit
that referenced
this pull request
May 28, 2025
# Description of the issue This PR fixes a panic issue described in #1702. # Description of changes `golang.org/x/text/cases.Caser.String` is not goroutine safe. In this PR, we initialize a new Caser when a metric processed by Application Signals is found with camel case naming. # License By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
There have been cases of the agent panicking from the capitalization of metrics in the Application Signals processor.
It's still unclear why the metric name capitalization is causing a panic.
Description of changes
cases.Caserper instance instead of shared within the package to prevent issues with shared state.https://pkg.go.dev/golang.org/x/text/cases#Caser
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added unit tests.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint