Conversation
Contributor
|
hmm, seems like the passing test run you linked is failing? https://github.com/aws/amazon-cloudwatch-agent/actions/runs/21013574773 |
Contributor
Author
I undid the change to point to my branch of the test repo and it made it weird for some reason. Anyway, created a temp branch and reran here: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/21075018664/job/60614650809
|
the-mann
approved these changes
Jan 22, 2026
movence
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of changes
As a follow up to #1965, add the missing ECR login step and also remove the unnecessary step for go test (which is now done as part of the
tf applyconsistent to our other integ tests).License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Passing GH run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/21013574773
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.