[ecs-patterns]: load balancer name of ApplicationLoadBalancerProps not working when creating ApplicationMultipleTargetGroupsEc2Service

[thehope2k]

Describe the bug

I'm creating an ecs service with multiple target groups using ecs_pattern module.

alb_props = ecs_patterns.ApplicationLoadBalancerProps(
            name="custom-alb-name",
            domain_name="*.example.com",
            domain_zone=route53.HostedZone.from_hosted_zone_attributes(
                self, "HostedZone",
                hosted_zone_id="xxxxxx",
                zone_name="example.com"
            ),
            listeners=[
                listener_1, listener2
            ],
            public_load_balancer=False
        )

ecs_service = ecs_patterns.ApplicationMultipleTargetGroupsEc2Service(
            self, "ECS-ID",
            service_name="service-name",
            cluster=cluster-name-ref,
            task_definition=task_definition,
            load_balancers=[alb_props],
            target_groups=[target_props_1, target_prop_2],
            cpu=1024,
            memory_reservation_mib=2048,
            desired_count=1
        )

Expected Behavior

The expected name of load balancer name should be "custom-alb-name"

Current Behavior

Load balancer name is auto-generated

Reproduction Steps

1. Create cdk
2. Wiring code like snip above
3. Run cdk deploy

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.54.0

Framework Version

No response

Node.js Version

v16.15.0

OS

Window

Language

Python

Language Version

python 3.11.1

Other information

No response

[thehope2k]

I'm not sure about this, but i found the issue in this snip code:

  private createLoadBalancer(name: string, publicLoadBalancer?: boolean, idleTimeout?: Duration): ApplicationLoadBalancer {
    const internetFacing = publicLoadBalancer ?? true;
    const lbProps = {
      vpc: this.cluster.vpc,
      internetFacing,
      idleTimeout: idleTimeout,
    };

    return new ApplicationLoadBalancer(this, name, lbProps);
  }

Line 596-695 in this file
https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-ecs-patterns/lib/base/application-multiple-target-groups-service-base.ts

I think it should be

  private createLoadBalancer(id: string, name?: string, publicLoadBalancer?: boolean, idleTimeout?: Duration): ApplicationLoadBalancer {
    const internetFacing = publicLoadBalancer ?? true;
    const lbProps = {
      vpc: this.cluster.vpc,
      internetFacing,
      idleTimeout: idleTimeout,
      loadBalancerName: name
    };

    return new ApplicationLoadBalancer(this, id, lbProps);
  }

[pahud]

Yes this seems to be a bug. Are you interested to submit a PR for that?

[thehope2k]

@pahud I want but i have no test environment and i have no idea how to verify it's works. @@

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.