-
Notifications
You must be signed in to change notification settings - Fork 4.5k
aws-cdk-lib.aws_ecs_patterns module: REMOVE_DEFAULT_DESIRED_COUNT is no longer supported in cdkv2 #29325
Description
Describe the issue
Currently the aws_ecs_patterns module docs reference the REMOVE_DEFAULT_DESIRED_COUNT flag in a few places:
The overall readme, on the feature flag:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs_patterns-readme.html#use-the-remove_default_desired_count-feature-flag
Similarly, individual patterns' docs reference the flag when discussing the desiredCount property, eg:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs_patterns.ApplicationLoadBalancedFargateService.html#desiredcount
Type: number (optional, default: If the feature flag, ECS_REMOVE_DEFAULT_DESIRED_COUNT is false, the default is 1; if true, the default is 1 for all new services and uses the existing services desired count when updating an existing service.)
However, when building a package using it, I see this error:
Error: Unsupported feature flag '@aws-cdk/aws-ecs-patterns:removeDefaultDesiredCount'. This flag existed on CDKv1 but has been removed in CDKv2. CDK will now behave as the same as when the flag is enabled.
You can see it on the unsupported list for v2 here.
These references in the docs should be removed, in favor of describing the (now unconditional) behavior with the feature enabled.