-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Assertions for AwsCustomResource integ tests (1/2) #29937
Description
Context
The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK. As a result, the SDK v2 handler used by AwsCustomResource is being removed. Several integ tests are impacted due to the changing asset hash and it was noted that none of these integ tests have assertions related to AwsCustomResource. To improve testing coverage we will be adding assertions to these integ tests.
Task Description
Update integ tests impacted by the removal of the SDK v2 handler to include assertions for AwsCustomResource where possible. Note that in some cases an assertion is not possible. For example, where the AwsCustomResource is making a describe related API call there will be nothing to assert against.
Acceptance Criteria
Investigate the following integ tests and add assertions where possible:
- @aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2/test/integ.alb.oidc.ts
- @aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.ts
- @aws-cdk-testing/framework-integ/test/aws-elasticsearch/test/integ.elasticsearch.custom-kms-key.ts
- @aws-cdk-testing/framework-integ/test/aws-elasticsearch/test/integ.elasticsearch.unsignedbasicauth.ts
- @aws-cdk-testing/framework-integ/test/aws-events-targets/test/logs/integ.log-group.ts
- @aws-cdk-testing/framework-integ/test/aws-globalaccelerator-endpoints/test/integ.globalaccelerator.ts
- @aws-cdk-testing/framework-integ/test/aws-logs-destinations/test/integ.lambda.ts
- @aws-cdk-testing/framework-integ/test/aws-opensearchservice/test/integ.opensearch.custom-kms-key.ts