feat(mixins-preview): cross account delivery destinations#36827
feat(mixins-preview): cross account delivery destinations#36827mergify[bot] merged 20 commits intomainfrom
Conversation
packages/@aws-cdk/mixins-preview/lib/services/aws-logs/logs-destination.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/mixins-preview/lib/services/aws-logs/logs-destination.ts
Outdated
Show resolved
Hide resolved
|
|
||||||||||||||
|
|
||||||||||||||
packages/@aws-cdk/mixins-preview/lib/services/aws-logs/logs-delivery.ts
Outdated
Show resolved
Hide resolved
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue StatusRule:
This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Separating out log delivery destinations from log delivery. This is mostly to enable cross account delivery with Vended Logs.
Description of changes
Moved code to set up delivery destinations into their own file with their own classes.
log-deliveryfile now uses the destination classes fromlog-destinations.Because of some naming changes the occurred while moving the delivery destinations out from the log delivery classes, all of the vended logs mixin integ tests were regenerated.
Describe any new or updated permissions being added
Adds permissions to enable cross account delivery for S3 and Firehose destinations when they are involved in cross account log delivery.
Only S3 Buckets and Firehose Delivery Streams can be involved in cross account delivery, Cloudwatch Log Groups and XRays cannot participate in cross account log delivery through Vended Logs.
See for permissions added: https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/vended-logs-crossaccount-example.html
Description of how you validated changes
Added new unit tests, updated existing integration tests, and added new integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license