Skip to content

feat(mixins-preview): cross account delivery destinations#36827

Merged
mergify[bot] merged 20 commits intomainfrom
vended-logs/destinations
Feb 26, 2026
Merged

feat(mixins-preview): cross account delivery destinations#36827
mergify[bot] merged 20 commits intomainfrom
vended-logs/destinations

Conversation

@ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Jan 30, 2026

Reason for this change

Separating out log delivery destinations from log delivery. This is mostly to enable cross account delivery with Vended Logs.

Description of changes

Moved code to set up delivery destinations into their own file with their own classes. log-delivery file now uses the destination classes from log-destinations.
Because of some naming changes the occurred while moving the delivery destinations out from the log delivery classes, all of the vended logs mixin integ tests were regenerated.

Describe any new or updated permissions being added

Adds permissions to enable cross account delivery for S3 and Firehose destinations when they are involved in cross account log delivery.
Only S3 Buckets and Firehose Delivery Streams can be involved in cross account delivery, Cloudwatch Log Groups and XRays cannot participate in cross account log delivery through Vended Logs.
See for permissions added: https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/vended-logs-crossaccount-example.html

Description of how you validated changes

Added new unit tests, updated existing integration tests, and added new integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 30, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team January 30, 2026 22:04
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jan 30, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 30, 2026
@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Jan 30, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results192 ran192 passed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates192 ran192 passed
TestResult
No test annotations available

@ShadowCat567 ShadowCat567 marked this pull request as ready for review February 19, 2026 14:45
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 19, 2026
@ShadowCat567 ShadowCat567 changed the title chore(mixins-preview): extract delivery destinations from logs delivery feat(mixins-preview): extract delivery destinations from logs delivery for cross account Feb 24, 2026
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 24, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 24, 2026 15:26

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-amplify-bot added 2 commits February 24, 2026 11:25
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 24, 2026
@mrgrain mrgrain changed the title feat(mixins-preview): extract delivery destinations from logs delivery for cross account feat(mixins-preview): cross accoun delivery destinations Feb 26, 2026
@mrgrain mrgrain changed the title feat(mixins-preview): cross accoun delivery destinations feat(mixins-preview): cross account delivery destinations Feb 26, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 26, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a759eb6 into main Feb 26, 2026
43 of 44 checks passed
@mergify mergify bot deleted the vended-logs/destinations branch February 26, 2026 11:18
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2026

Merge Queue Status

Rule: default-squash


  • Entered queue2026-02-26 11:17 UTC
  • Checks passed · in-place
  • Merged2026-02-26 11:18 UTC · at 40940dfc41299997c72ec061cf6549648d4e0f4b

This pull request spent 6 seconds in the queue, with no time running CI.

Required conditions to merge

@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants