feat(cli): abort cli execution on invalid options#27843
feat(cli): abort cli execution on invalid options#27843
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
scanlonp
left a comment
There was a problem hiding this comment.
I think this change is good conceptually but may have some unintended consequences. Would this break user pipelines or other workflows if their cli commands have extra options?
There are also some of our existing tests failing with this change. Can you look into why those are failing?
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Adds
.strictOptions()to yargs.Closes #27723
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license