feat(gamelift): support Build serverSdkVersion, updated OperatingSystem values

[lpizzinidev]

Some adjustments to Build properties:

• Adds support for serverSdkVersion attribute
• Updates list of available operatingSystem and deprecates Windows Server 2012

Closes #27655.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[scanlonp]

Looks great! A minor nit on the error message, and then it should be good to go. Edited the error message.

One concern. Should serverSdkVersion be a public attribute on the Build and Import classes? It looks like the rest of the parameters are.

Pull request has been modified.

[go-to-k]

Looks good to me. I had to comment on a couple of points.

[go-to-k]

It will be passed if a string is empty, so I would prefer an undefined check. And I think it should take the case that the param is Token by CfnParameter, etc., what do you think?

Suggested change

	if (!serverSdkVersion) return;
	if (serverSdkVersion === undefined || Token.isUnresolved(serverSdkVersion)) return;

[go-to-k]

I think it would be better to output the length of a character in the error message. I have seen other cases like this.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/sagemaker/create-training-job.ts#L341
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-events-targets/lib/batch.ts#L118
https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-glue-alpha/lib/database.ts#L136

Suggested change

	throw new Error(`serverSdkVersion length must be smaller than or equal to 128, got ${serverSdkVersion}.`);
	throw new Error(`serverSdkVersion length must be smaller than or equal to 128, got ${serverSdkVersion.length}.`);

[go-to-k]

Oh, sorry, @scanlonp already reviewed.

[lpizzinidev]

@go-to-k
Nice catches! I missed both of them 😄

@scanlonp
Some of the props are exposed, but others are not.
Unless there is a specific need to provide a reference to serverSdkVersion outside of the class I would keep it private.

[go-to-k]

@lpizzinidev Thanks! I approved.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 15de967
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).