chore: bump @aws-cdk/asset-awscli-v1 version#27881
Merged
mergify[bot] merged 13 commits intomainfrom Nov 8, 2023
Merged
Conversation
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
sumupitchayan
approved these changes
Nov 7, 2023
vinayak-kukreja
added
the
pr/do-not-merge
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
…ntent Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
…ed-bucket Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
…ront Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
…beanstalk-deploy Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
vinayak-kukreja
commented
Nov 8, 2023
| environmentName: 'codepipeline-test-env', | ||
| // see https://docs.aws.amazon.com/elasticbeanstalk/latest/platforms/platforms-supported.html#platforms-supported.nodejs | ||
| solutionStackName: '64bit Amazon Linux 2023 v6.0.0 running Node.js 18', | ||
| solutionStackName: '64bit Amazon Linux 2023 v6.0.2 running Node.js 18', |
Contributor
Author
There was a problem hiding this comment.
This was outdated and the integ test was failing:
The stack named aws-cdk-codepipeline-elastic-beanstalk-deploy failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Resource handler returned message: "No Solution Stack named '64bit Amazon Linux 2023 v6.0.0 running Node.js 18' found. (Service: ElasticBeanstalk, Status Code: 400, Request ID: 753eedce-7198-4f51-96ed-f4d2f06a9259)" (RequestToken: 0fa2c53a-b816-8755-5b0c-48386ab111ce, HandlerErrorCode: InvalidRequest)
FAILED aws-codepipeline-actions/test/integ.pipeline-elastic-beanstalk-deploy-codepipeline-elastic-beanstalk-deploy/DefaultTest (undefined/us-east-1) 207.555s
Integration test failed: Error: Command exited with status 1
sumupitchayan
approved these changes
Nov 8, 2023
sumupitchayan
removed
the
pr/do-not-merge
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
vinayak-kukreja
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit 610d9ac.
mikewrighton
pushed a commit
that referenced
this pull request
Nov 13, 2023
I released a newer version of this library but it has not made to the cdk repo yet. Upgrading this could help with resolving a security issue: #27661 Needed to run multiple integ tests for this and got warnings similar to following: ``` Stack: test-bucket-deployment-deployed-bucket - Resource: DeployMe5AwsCliLayerF0F79631 - Impact: WILL_REPLACE !!! If these destructive changes are necessary, please indicate this on the PR !!! Failed: /Users/vinakuk/Desktop/Work/Repositories/CDK/Ops/Security-Issue/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-s3-deployment/test/integ.bucket-deployment-signcontent.js !!! This test contains destructive changes !!! ``` I believe this is expected since the version of the library is changing. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I released a newer version of this library but it has not made to the cdk repo yet. Upgrading this could help with resolving a security issue: #27661
Needed to run multiple integ tests for this and got warnings similar to following:
I believe this is expected since the version of the library is changing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license