Skip to content

chore(redshift-alpha): migrate cluster parameter change reboot handler#27883

Merged
mergify[bot] merged 5 commits intomainfrom
colifran/migrate-cluster-change-reboot
Nov 8, 2023
Merged

chore(redshift-alpha): migrate cluster parameter change reboot handler#27883
mergify[bot] merged 5 commits intomainfrom
colifran/migrate-cluster-change-reboot

Conversation

@colifran
Copy link
Copy Markdown
Contributor

@colifran colifran commented Nov 7, 2023

This PR moves the cluster parameter change reboot handler from aws-cdk-lib to our new centralized location for custom resource handlers in the @aws-cdk package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Francis added 3 commits November 6, 2023 17:40
Signed-off-by: Francis <colifran@amazon.com>
wip
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@github-actions github-actions bot added the p2 label Nov 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 7, 2023 22:17
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 7, 2023
@colifran colifran marked this pull request as ready for review November 7, 2023 22:47
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 7, 2023
Francis and others added 2 commits November 7, 2023 15:24
@vinayak-kukreja vinayak-kukreja self-assigned this Nov 8, 2023
"@aws-cdk/cdk-build-tools": "0.0.0",
"@aws-cdk/integ-runner": "0.0.0",
"@aws-cdk/pkglint": "0.0.0",
"@aws-cdk/custom-resource-handlers": "0.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be calculated at build?

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 53c8d48
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0f168f1 into main Nov 8, 2023
@mergify mergify bot deleted the colifran/migrate-cluster-change-reboot branch November 8, 2023 19:36
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
#27883)

This PR moves the cluster parameter change reboot handler from aws-cdk-lib to our new centralized location for custom resource handlers in the [@aws-cdk](https://github.com/aws-cdk) package.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. handler-migration p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants