Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Preparing for node20 launch ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Preparing for node20 launch ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
| /** | ||
| * The NodeJS 20.x runtime (nodejs20.x) | ||
| */ | ||
| public static readonly NODEJS_20_X = new Runtime('nodejs20.x', RuntimeFamily.NODEJS, { supportsInlineCode: true }); |
There was a problem hiding this comment.
Is it an oversight or intentional that NODEJS_LATEST has not been updated as part of this PR?
There was a problem hiding this comment.
Nicely spotted, guess it will be changed at a later point.
According to the PR description this is just for "Preparing for node20 launch".
Preparing for node20 launch
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license