fix(cloudformation-diff): cdk diff throws toUpperCase is not a function when ipProtocol is a number#28023
fix(cloudformation-diff): cdk diff throws toUpperCase is not a function when ipProtocol is a number#28023mergify[bot] merged 6 commits intoaws:mainfrom gastonsilva:fix/diff-ipprotocol-describe
cdk diff throws toUpperCase is not a function when ipProtocol is a number#28023Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
cdk diff throws this.ipProtocol.toUpperCase is not a function when ipProtocol is a number
cdk diff throws this.ipProtocol.toUpperCase is not a function when ipProtocol is a numbercdk diff throws toUpperCase is not a function when ipProtocol is a number
cdk diff throws toUpperCase is not a function when ipProtocol is a numbercdk diff throws toUpperCase is not a function when ipProtocol is a number
|
Hey @gastonsilva , thank you for your contribution. I am confirming with the team if an exemption could be granted for this PR. Other than that, the changes looks good to me. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fix the describe protocol method when running a diff with a processed existing cloudformation template that has a security group rule with ipprotocol = -1
Closes #28021
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license