feat(cloudfront): CloudFront Function runtime property by watany-dev · Pull Request #28099 · aws/aws-cdk

watany-dev · 2023-11-22T07:55:01Z

fixed #28163
This provides an option to change the runtime for CloudFront Functions. This makes it easier to access the CloudFront KeyValueStore.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-functionconfig.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

watany-dev · 2023-11-22T09:48:26Z

Sorry, I think it's failing to push the snapshot.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

This reverts commit 757a212.

Pull request has been modified.

…into cf2-runtime2

go-to-k · 2023-11-24T14:20:45Z

...-cdk-testing/framework-integ/test/aws-cloudfront/test/integ.distribution-function-runtime.ts

+const cfFunctionRequest = new cloudfront.Function(stack, 'FunctionRequest', {
+  code: cloudfront.FunctionCode.fromInline('function handler(event) { return event.request }'),
+});
+
+const cfFunctionResponse = new cloudfront.Function(stack, 'FunctionResponse', {
+  code: cloudfront.FunctionCode.fromInline('function handler(event) { return event.response }'),
+});


In my opinion, it would be better to use a new parameter FunctionRuntime.JS_2_0 as well, what do you think?

Sorry, It seems that @mikewrighton previously approved. See this comment if you need me to, otherwise I just approve.

What you say is true. I am happy to report that I have changed to a meaningful integ test

Pull request has been modified.

packages/aws-cdk-lib/aws-cloudfront/lib/function.ts

kaizencc

Thanks @watany-dev!

Pull request has been modified.

kaizencc · 2023-12-28T02:15:19Z

packages/aws-cdk-lib/aws-cloudfront/lib/function.ts

+  /**
+   * The Runtime of the function.
+   */
+  readonly functionRuntime: string;


Suggested change

readonly functionRuntime: string;

readonly functionRuntime?: string;

Build is failing with:

err - IFACE aws-cdk-lib.aws_cloudfront.FunctionAttributes: newly required property 'functionRuntime' added: input to aws-cdk-lib.aws_cloudfront.Function.fromFunctionAttributes [strengthened:aws-cdk-lib.aws_cloudfront.FunctionAttributes]

Looks like we cannot require this prop to fromFunctionAttributes and instead will have to default to the original runtime, or throw an error if not provided.

@watany-dev

@kaizencc
We decided to make it an arbitrary property. If not specified, the Default value, runtime1.0, is specified as before.

…into cf2-runtime2

mergify · 2023-12-29T04:07:40Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2023-12-29T04:34:25Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 783aed1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-12-29T04:34:46Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

fixed aws#28163 This provides an option to change the runtime for CloudFront Functions. This makes it easier to access the CloudFront KeyValueStore. https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-functionconfig.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

#28099 added this file erroneously. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(cloudfront): Setting Runtime of CF2

28ab0c3

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 22, 2023

aws-cdk-automation requested a review from a team November 22, 2023 07:55

aws-cdk-automation previously requested changes Nov 22, 2023

View reviewed changes

watany-dev added 2 commits November 22, 2023 08:00

readme

9f54b1c

integ

8673979

snapshot

757a212

mikewrighton changed the title ~~feat(cloudfront): Setting Runtime of CF2~~ feat(cloudfront): setting Runtime of CF2 Nov 22, 2023

mikewrighton previously approved these changes Nov 22, 2023

View reviewed changes

mikewrighton changed the title ~~feat(cloudfront): setting Runtime of CF2~~ feat(cloudfront): setting the runtime of a CloudFront Function Nov 22, 2023

watany-dev added 2 commits November 22, 2023 15:26

Revert "snapshot"

d3fb723

This reverts commit 757a212.

integ

0b165cd

watany-dev added 3 commits November 23, 2023 00:50

Merge branch 'main' into cf2-runtime2

858e821

fix readme

c209632

Merge branch 'cf2-runtime2' of https://github.com/watany-dev/aws-cdk …

a74e730

…into cf2-runtime2

watany-dev requested a review from mikewrighton November 22, 2023 16:46

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2023

Merge branch 'aws:main' into cf2-runtime2

e80fa76

go-to-k suggested changes Nov 24, 2023

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 24, 2023

watany-dev added 2 commits November 26, 2023 00:23

Merge branch 'aws:main' into cf2-runtime2

204bfe4

update integ

a4d220c

go-to-k approved these changes Nov 26, 2023

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 26, 2023

go-to-k mentioned this pull request Nov 28, 2023

aws-cloudfront: Support cloudfront-js-2.0 runtime #28163

Closed

2 tasks

github-actions bot added the feature-request A feature should be added or improved. label Nov 28, 2023

github-actions bot added the effort/medium Medium work item – several days of effort label Dec 18, 2023

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 18, 2023

Merge branch 'aws:main' into cf2-runtime2

77dc039

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 21, 2023

watany-dev added 2 commits December 21, 2023 14:34

enum to class

7d82d0e

fix lint

18b4cfe

kaizencc reviewed Dec 22, 2023

View reviewed changes

packages/aws-cdk-lib/aws-cloudfront/lib/function.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-cloudfront/lib/function.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

170ea4b

kaizencc previously approved these changes Dec 22, 2023

View reviewed changes

Merge branch 'main' into cf2-runtime2

96ba2d0

Merge branch 'main' into cf2-runtime2

1c35ae2

kaizencc reviewed Dec 28, 2023

View reviewed changes

watany-dev added 5 commits December 28, 2023 02:52

optional

50e9ca5

optional

b0eebba

Merge branch 'cf2-runtime2' of https://github.com/watany-dev/aws-cdk …

87bc78e

…into cf2-runtime2

default

968fe51

Merge branch 'main' into cf2-runtime2

4819dad

kaizencc approved these changes Dec 29, 2023

View reviewed changes

Merge branch 'main' into cf2-runtime2

783aed1

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 29, 2023

mergify bot merged commit 9b466ae into aws:main Dec 29, 2023

kaizencc mentioned this pull request Feb 5, 2024

chore: remove erroneously committed file #28992

Merged

mergify bot pushed a commit that referenced this pull request Feb 6, 2024

chore: remove erroneously committed file (#28992)

17826b4

#28099 added this file erroneously. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

	readonly functionRuntime: string;
	readonly functionRuntime?: string;

Conversation

watany-dev commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

watany-dev commented Nov 22, 2023

Uh oh!

go-to-k Nov 24, 2023

Choose a reason for hiding this comment

Uh oh!

go-to-k Nov 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

watany-dev Nov 25, 2023

Choose a reason for hiding this comment

Uh oh!

go-to-k Nov 26, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaizencc left a comment

Choose a reason for hiding this comment

Uh oh!

kaizencc Dec 28, 2023

Choose a reason for hiding this comment

Uh oh!

kaizencc Dec 28, 2023

Choose a reason for hiding this comment

Uh oh!

watany-dev Dec 28, 2023

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Dec 29, 2023

Uh oh!

aws-cdk-automation commented Dec 29, 2023

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Dec 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

watany-dev commented Nov 22, 2023 •

edited

Loading

go-to-k Nov 24, 2023 •

edited

Loading