chore(cli): cli import code never reaches "??" operator

[kaizencc]

We're seeing this linter error flag: Warning: G] The "??" operator here will always return the left operand [suspicious-nullish-coalescing] in the yarn upgrade task.

It is because const defaultValue = typeof resourceProps[idProp] ?? ''; never reaches the ?? since typeof returns a string (returns "undefined" when the type its looking at is undefined). The code in question is buggy, but also ambiguous in meaning. It could mean:

const defaultValue = typeof (resourceProps[idProp] ?? '');, which means that we want defaultValue === 'string' when resourceProps[idProp] === undefined.

or

const defaultValue = resourceProps[idProp] ? typeof resourceProps[idProp] : '';, which means that we want defaultValue === '' when resourceProps[idProp] === undefined.

Later on we use defaultValue as the condition in a ternary operator. This tells me that the latter is the correct way to interpret the code's intention, since '' evaluates to false. All other options, including 'string' and 'undefined', evaluate to true.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 651d67a
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).