fix(spec2cdk): attributes in ICfnResource should not be optional#28179
Merged
kaizencc merged 2 commits intoconroy/generatefrom Nov 29, 2023
Merged
fix(spec2cdk): attributes in ICfnResource should not be optional#28179kaizencc merged 2 commits intoconroy/generatefrom
ICfnResource should not be optional#28179kaizencc merged 2 commits intoconroy/generatefrom
Conversation
aws-cdk-automation
previously requested changes
Nov 28, 2023
Collaborator
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They should all be required. Anything returned from
refwill exist, even if the property itself is not required. For example,CfnBucket.attrBucketNameis not required in the resource spec because you can either specify a bucket name or have one generated for you. However, when accessing it viaref, the bucket name will certainly exist, so it is not optional.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license