feat(appconfig-alpha): support for relative file paths when importing config#28191
feat(appconfig-alpha): support for relative file paths when importing config#28191mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
github-actions
bot
added
effort/small
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
left a comment
lpizzinidev
left a comment
There was a problem hiding this comment.
Looks good 👍
Just a minor documentation nit.
| Lambda function. | ||
| See [About validators](https://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-creating-configuration-and-profile.html#appconfig-creating-configuration-and-profile-validators) for more information. | ||
|
|
||
| When you import a JSON Schema validator from a file, you can pass in a relative path. |
There was a problem hiding this comment.
Can you please update here as well?
* `fromFile` - Defines the hosted configuration content from a file (you can specify a relative path).
vinayak-kukreja
changed the title
vinayak-kukreja
left a comment
vinayak-kukreja
left a comment
There was a problem hiding this comment.
Hey @chenjane-dev , thank you for this contribution.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… config (aws#28191) When importing a config from a file, you can now pass a relative path (`config.json`) instead of the absolute path (`/Users/..../config.json`). Closes aws#26937. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 participants
When importing a config from a file, you can now pass a relative path (
config.json) instead of the absolute path (/Users/..../config.json).Closes #26937.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license