Skip to content

fix(core): messages from annotations.ts can show up as [object Object] #28414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Dec 18, 2023
Merged

fix(core): messages from annotations.ts can show up as [object Object] #28414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81b1861
Fix: messages from annotations.ts somehow shows up as [object Object]
lmammino Dec 18, 2023
27d41c5
Update packages/aws-cdk-lib/core/lib/annotations.ts
kaizencc Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/aws-cdk-lib/core/lib/annotations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ export class Annotations {
private addMessage(level: string, message: string) {
const isNew = !this.scope.node.metadata.find((x) => x.data === message);
if (isNew) {
this.scope.node.addMetadata(level, message, { stackTrace: this.stackTraces });
let normalizedMessage = typeof message === 'string' ? message : JSON.stringify(message);
this.scope.node.addMetadata(level, normalizedMessage, { stackTrace: this.stackTraces });
}
}
}
Expand Down Expand Up @@ -259,4 +260,4 @@ function removeWarning(construct: IConstruct, id: string) {

function ackTag(id: string) {
return `[ack: ${id}]`;
}
}