Skip to content

fix(lambda-python-alpha): pass architecture property to function#28443

Closed
mapk-amazon wants to merge 1 commit intoaws:mainfrom
mapk-amazon:mapk-amazon-patch-architecture-for-lambda-alpha
Closed

fix(lambda-python-alpha): pass architecture property to function#28443
mapk-amazon wants to merge 1 commit intoaws:mainfrom
mapk-amazon:mapk-amazon-patch-architecture-for-lambda-alpha

Conversation

@mapk-amazon
Copy link
Copy Markdown

By default Lambda will take x86 architecture, which might get into conflict with layers/code. With this change the architecture information is passed along and the correct architecture for the docker image is chosen.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

By default Lambda will take x86 architecture, which might get into conflict with layers/code.
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 20, 2023 19:00
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mapk-amazon mapk-amazon changed the title Added architecture information for processing fix: Added architecture information for processing Dec 20, 2023
@mapk-amazon mapk-amazon changed the title fix: Added architecture information for processing fix(lambda-alpha): Added architecture information for processing Dec 20, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 98820ac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc kaizencc changed the title fix(lambda-alpha): Added architecture information for processing fix(lambda-python-alpha): pass architecture property to function Dec 21, 2023
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mapk-amazon, we need a unit test to go along with this change to ensure that it works. Are you up for that?

@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Dec 21, 2023
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by #28449

@kaizencc kaizencc closed this Dec 21, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants