Skip to content

fix(aws-lambda): Fix the log format type on logging configurations#28475

Closed
AnuragMohapatra wants to merge 1 commit intoaws:mainfrom
AnuragMohapatra:fix-28127-Logformatoptionisuntyped
Closed

fix(aws-lambda): Fix the log format type on logging configurations#28475
AnuragMohapatra wants to merge 1 commit intoaws:mainfrom
AnuragMohapatra:fix-28127-Logformatoptionisuntyped

Conversation

@AnuragMohapatra
Copy link
Copy Markdown
Contributor

Updated the logFormat property type from string to LogFormat

Closes #28114 .


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 23, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2023 00:28
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@AnuragMohapatra
Copy link
Copy Markdown
Contributor Author

There is already a PR #28127

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title of the pull request should omit 'aws-' from the name of modified packages. Use 'lambda' instead of 'aws-lambda'.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ee1b972
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. effort/small Small work item – less than a day of effort p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-lambda: Log format option is not typed

2 participants