feat(autoscaling): add support for InstanceRefresh suspended process

[mulmar-aws]

Also add InstanceRefresh as a default suspended process for RollingUpdate.

I have also submitted a request to update https://repost.aws/knowledge-center/auto-scaling-group-rolling-updates to conform with this change.

Reason for this change

Instance Refresh is a feature of ASG. It performs a similar function to Rolling Update. If an Instance Refresh is running at the same time as a Rolling Update, the Rolling Update will fail. It is safer to suspend the process.

Description of changes

See above.

Description of how you validated changes

Unit tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[xazhao]

Hello @mulmar-aws there are other tests failing which is because of missing InstanceRefresh. Could you please add it to the failing test? Also is integration test needed for this PR?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mulmar-aws]

I think I have the integration test set up properly but I see some automated checks are failing. Let me know if I've made a mistake here!

> yarn integ --update-on-failed aws-autoscaling/test/integ.asg-update-policy.js
yarn run v1.22.21
$ integ-runner --language javascript --update-on-failed aws-autoscaling/test/integ.asg-update-policy.js

Verifying integration test snapshots...

  UNCHANGED  aws-autoscaling/test/integ.asg-update-policy 0.538s

Snapshot Results:

Tests:    1 passed, 1 total

Running integration tests for failed tests...

Running in parallel across regions: us-east-1, us-east-2, us-west-2

Test Results:

Tests:    0 passed, 0 total
✨  Done in 1.25s.

[mulmar-aws]

Hello, just following up to see if more changes are required?

[xazhao]

The change looks good to me. Just one question: should the title be feat instead of fix?

[mulmar-aws]

Good point. Changed.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mulmar-aws]

Exemption Request : I don't think there is anything to change in a README file here - suspended processes are not called out in detail in the AutoScaling README.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[xazhao]

Looks good to me

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: fd14634
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).