chore(msk-alpha): update KafkaVersion#29440
Merged
Conversation
github-actions
bot
added
p2
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
msambol
approved these changes
Mar 11, 2024
Contributor
msambol
left a comment
msambol
left a comment
There was a problem hiding this comment.
LGTM. From the docs:
The Amazon MSK cluster with tiered storage enabled must use version 3.6.0 or 2.8.2.tiered.
aws-cdk-automation
added
pr/needs-maintainer-review
GavinZZ
previously requested changes
Mar 12, 2024
Member
GavinZZ
left a comment
GavinZZ
left a comment
There was a problem hiding this comment.
Overall LGTM just one README update comment
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
GavinZZ
approved these changes
Mar 13, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
obraafo
pushed a commit
to obraafo/aws-cdk
that referenced
this pull request
Apr 1, 2024
### Issue # (if applicable) Could not find any in the backlog ### Reason for this change Update the CDK listed Kafka versions to match the current availability, as well as add missing deprecated versions ### Description of changes * Added latest version * `3.6.0` also supports tiered storage, see [docs](https://docs.aws.amazon.com/msk/latest/developerguide/msk-tiered-storage.html#msk-tiered-storage-requirements). I replaced the prefix check with a list of supported versions, as I'm not sure if say every reason after 3.6.0 will support it, and the `.tiered` prefix isn't consistently applied anymore * Added two unlisted, deprecated versions, as they are still returned by the SDK. The goal is to remove any differences between the SDK and the CDK to ease future automation ### Description of how you validated changes I compared the current CDK versions to live SDK data, using the `kafka:ListKafkaVersions` API results. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: GZ <yuanhaoz@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Could not find any in the backlog
Reason for this change
Update the CDK listed Kafka versions to match the current availability, as well as add missing deprecated versions
Description of changes
3.6.0also supports tiered storage, see docs. I replaced the prefix check with a list of supported versions, as I'm not sure if say every reason after 3.6.0 will support it, and the.tieredprefix isn't consistently applied anymoreDescription of how you validated changes
I compared the current CDK versions to live SDK data, using the
kafka:ListKafkaVersionsAPI results.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license